fix: restrict ProjectShowcase to root pages and fix clice doc links#15
Merged
Conversation
HomeHeroProjects was rendering on all `layout: home` pages, including /clice/. Add v-if to only show on root pages (/ and /zh/). Also fix clice index.md hero links from absolute to relative paths so they resolve correctly under /clice/ prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HomeHeroProjectswas rendering on alllayout: homepages (including/clice/), showing the main site's project showcase on subproject pages. Addv-ifto restrict it to root pages only (/and/zh/).index.mdhero action links from absolute (/guide/...) to relative (./guide/...) so they resolve correctly under the/clice/prefix.Test plan
/— ProjectShowcase should appear/clice/— only clice hero + features, no ProjectShowcase/clice/— navigates to/clice/guide/what-is-clice/zh/and/zh/clice/