feature(frontend, cliq_term): Allow changing session title#537
Draft
DenuxPlays wants to merge 10 commits into
Draft
feature(frontend, cliq_term): Allow changing session title#537DenuxPlays wants to merge 10 commits into
DenuxPlays wants to merge 10 commits into
Conversation
- add support for custom labels - added menu to custom context menu to allow for renaming
- applied some review form copilot (lol)
- keep custom label - added tests for label changes
jasonlessenich
requested changes
Jun 10, 2026
| ShellSession? root, | ||
| List<ShellSession>? sessions, | ||
| String? label, | ||
| bool clearLabel = false, |
Contributor
There was a problem hiding this comment.
I would remove this and just handle an empty string as "clear"
| .new( | ||
| label: 'Rename', | ||
| icon: LucideIcons.edit, | ||
| onPress: () { |
Contributor
There was a problem hiding this comment.
I'd suggest moving this to a function and also allowing to double click the session title to edit it inline
| showFDialog( | ||
| context: Router.rootNavigatorKey.currentContext ?? context, | ||
| builder: (dialogContext, style, animation) { | ||
| return FDialog( |
Contributor
There was a problem hiding this comment.
Not sure about using a separate dialog here.. I think being able to edit the name inline would be better
this would require swapping the Text that displays the label with a TextField when editing is active
jasonlessenich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #535
TODO cliq_term
TODO frontend