Skip to content

fix: make stat() Windows-compatible by guarding os.getegid/geteuid #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rohan5commit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make stat() Windows-compatible by guarding os.getegid/geteuid #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/celpy/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import logging.config
import os
from pathlib import Path
import platform
import re
import stat as os_stat
import sys
Expand All @@ -46,6 +47,8 @@

logger = logging.getLogger("celpy")

_IS_WINDOWS = platform.system() == "Windows"


# For argument parsing purposes.
# Note the reliance on `ast.literal_eval` for ListType and MapType conversions.
Expand Down Expand Up @@ -236,10 +239,14 @@ def get_options(argv: Optional[List[str]] = None) -> argparse.Namespace:


def stat(path: Union[Path, str]) -> Optional[celtypes.MapType]:
"""This function is added to the CLI to permit file-system interrogation."""
"""This function is added to the CLI to permit file-system interrogation.

On Windows, ``group_access`` and ``user_access`` are omitted because
``os.getegid()`` and ``os.geteuid()`` are not available on that platform.
"""
try:
status = Path(path).stat()
data = {
data: Dict[str, celtypes.Value] = {
"st_atime": celtypes.TimestampType(
datetime.datetime.fromtimestamp(status.st_atime)
),
Expand All @@ -253,10 +260,14 @@ def stat(path: Union[Path, str]) -> Optional[celtypes.MapType]:
"st_ino": celtypes.IntType(status.st_ino),
"st_nlink": celtypes.IntType(status.st_nlink),
"st_size": celtypes.IntType(status.st_size),
"group_access": celtypes.BoolType(status.st_gid == os.getegid()),
"user_access": celtypes.BoolType(status.st_uid == os.geteuid()),
}

# group_access and user_access rely on os.getegid()/os.geteuid(),
# which are not available on Windows.
if not _IS_WINDOWS:
data["group_access"] = celtypes.BoolType(status.st_gid == os.getegid()) # type: ignore[attr-defined]
data["user_access"] = celtypes.BoolType(status.st_uid == os.geteuid()) # type: ignore[attr-defined]

# From mode File type:
# - block, character, directory, regular, symbolic link, named pipe, socket
# One predicate should be True; we want the code for that key.
Expand Down
Loading