Prevent IME composition from submitting chat - #201
Closed
Maklu wants to merge 1 commit into
Closed
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Prevents the chat composer from treating Enter and other keyboard shortcuts as commands while an IME composition is active. This fixes the existing bug reported in #81, where confirming a Chinese, Japanese, or Korean candidate could submit the message.
The guard covers both the standard
KeyboardEvent.isComposingsignal and the legacy process-key value (keyCode === 229). Focused tests cover composition Enter, legacy process-key Enter, and ordinary Enter.Why is this obviously correct and trivially verifiable?
The complete behavior is contained in one pure predicate and one early return in the existing keydown handler. When composition is active, the handler does nothing and leaves the event to the IME. When it is not active, execution continues through the unchanged keyboard handling path. The regression tests exercise both branches directly.
Validation
pnpm --filter @gadgets/workshop-frontend exec tsc --noEmitpnpm --filter @gadgets/workshop-frontend test(29 files, 153 tests passed)Checklist
Closes #81