Skip to content

Refactor bitbucket to use Commenter interface#1844

Merged
prymitive merged 1 commit into
mainfrom
bb
May 28, 2026
Merged

Refactor bitbucket to use Commenter interface#1844
prymitive merged 1 commit into
mainfrom
bb

Conversation

@prymitive
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.84.0-31-g479c4771
Number of rules parsed 9
Number of rules checked 9
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@github-actions
Copy link
Copy Markdown

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 9V74 80-Core Processor                
                    │   old.txt   │              new.txt               │
                    │   sec/op    │   sec/op     vs base               │
GlobFinder-4          18.81m ± 1%   18.73m ± 2%       ~ (p=0.280 n=10)
GitFinder-4           394.3m ± 1%   392.0m ± 1%  -0.59% (p=0.003 n=10)
CheckRules-4           9.730 ± 1%    9.710 ± 1%       ~ (p=0.853 n=10)
RuleIsIdentical-4     7.086m ± 0%   7.081m ± 3%       ~ (p=0.971 n=10)
GetChecksForEntry-4   115.0m ± 1%   116.7m ± 1%  +1.54% (p=0.001 n=10)
geomean               142.5m        142.6m       +0.05%

                    │    old.txt     │                new.txt                │
                    │      B/op      │     B/op      vs base                 │
GlobFinder-4          7.107Mi ± 0%     7.107Mi ± 0%       ~ (p=0.089 n=10)
GitFinder-4           15.74Mi ± 1%     15.74Mi ± 1%       ~ (p=0.684 n=10)
CheckRules-4          901.5Mi ± 0%     900.8Mi ± 0%       ~ (p=0.796 n=10)
RuleIsIdentical-4       0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=10) ¹
GetChecksForEntry-4   57.56Mi ± 0%     57.56Mi ± 0%       ~ (p=0.481 n=10)
geomean                            ²                 -0.01%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                    │    old.txt    │               new.txt                │
                    │   allocs/op   │  allocs/op   vs base                 │
GlobFinder-4          110.6k ± 0%     110.6k ± 0%       ~ (p=1.000 n=10)
GitFinder-4           142.9k ± 0%     142.9k ± 0%       ~ (p=0.838 n=10)
CheckRules-4          9.729M ± 0%     9.725M ± 0%       ~ (p=0.218 n=10)
RuleIsIdentical-4      0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=10) ¹
GetChecksForEntry-4   963.7k ± 0%     963.7k ± 0%       ~ (p=0.165 n=10)
geomean                           ²                -0.01%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/cloudflare/pint/internal/diags
                             │   old.txt   │              new.txt               │
                             │   sec/op    │   sec/op     vs base               │
InjectDiagnosticsLongExpr-4    6.129µ ± 0%   6.129µ ± 1%       ~ (p=0.725 n=10)
InjectDiagnosticsShortExpr-4   997.1n ± 0%   979.0n ± 0%  -1.81% (p=0.000 n=10)
geomean                        2.472µ        2.450µ       -0.91%

                             │   old.txt    │                new.txt                │
                             │     B/op     │     B/op      vs base                 │
InjectDiagnosticsLongExpr-4    3.578Ki ± 0%   3.578Ki ± 0%       ~ (p=1.000 n=10) ¹
InjectDiagnosticsShortExpr-4     304.0 ± 0%     304.0 ± 0%       ~ (p=1.000 n=10) ¹
geomean                        1.031Ki        1.031Ki       +0.00%
¹ all samples are equal

                             │  old.txt   │               new.txt               │
                             │ allocs/op  │ allocs/op   vs base                 │
InjectDiagnosticsLongExpr-4    39.00 ± 0%   39.00 ± 0%       ~ (p=1.000 n=10) ¹
InjectDiagnosticsShortExpr-4   13.00 ± 0%   13.00 ± 0%       ~ (p=1.000 n=10) ¹
geomean                        22.52        22.52       +0.00%
¹ all samples are equal

pkg: github.com/cloudflare/pint/internal/parser
        │   old.txt   │              new.txt               │
        │   sec/op    │   sec/op     vs base               │
Parse-4   16.52m ± 2%   16.20m ± 1%  -1.95% (p=0.001 n=10)

        │   old.txt    │            new.txt             │
        │     B/op     │     B/op      vs base          │
Parse-4   6.387Mi ± 0%   6.387Mi ± 0%  ~ (p=0.810 n=10)

        │   old.txt   │             new.txt             │
        │  allocs/op  │  allocs/op   vs base            │
Parse-4   102.8k ± 0%   102.8k ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

pkg: github.com/cloudflare/pint/internal/parser/source
               │   old.txt   │            new.txt            │
               │   sec/op    │   sec/op     vs base          │
LabelsSource-4   6.980m ± 1%   7.008m ± 1%  ~ (p=0.529 n=10)

               │   old.txt    │            new.txt             │
               │     B/op     │     B/op      vs base          │
LabelsSource-4   5.743Mi ± 0%   5.745Mi ± 0%  ~ (p=0.315 n=10)

               │   old.txt   │            new.txt            │
               │  allocs/op  │  allocs/op   vs base          │
LabelsSource-4   47.12k ± 0%   47.12k ± 0%  ~ (p=0.511 n=10)

pkg: github.com/cloudflare/pint/internal/promapi
                    │   old.txt   │            new.txt            │
                    │   sec/op    │   sec/op     vs base          │
QueryCacheOnlySet-4   108.9n ± 0%   109.1n ± 3%  ~ (p=0.219 n=10)

                    │  old.txt   │            new.txt             │
                    │    B/op    │    B/op     vs base            │
QueryCacheOnlySet-4   64.00 ± 0%   64.00 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

                    │  old.txt   │            new.txt             │
                    │ allocs/op  │ allocs/op   vs base            │
QueryCacheOnlySet-4   1.000 ± 0%   1.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1e89357) to head (479c477).

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #1844    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          115       114     -1     
  Lines        14764     14494   -270     
==========================================
- Hits         14764     14494   -270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prymitive prymitive merged commit 29053ad into main May 28, 2026
20 checks passed
@prymitive prymitive deleted the bb branch May 28, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants