cid: improve DCID retirement handling#2517
Merged
Merged
Conversation
antoniovicente
approved these changes
Jun 24, 2026
Member
|
Nit: |
The `dcids` ConnectionIdVecDeque is not guaranteed to be sorted, so plainly applying `self.dcids.inner.partition_point(...)` can lead to incorrect result. While we could introduce such a guarantee, it would require spending more cycles when handling out-of-order sequence numbers. Instead, this change checks all elements in O(n) time. While it is possible to optimize further to take advantage of an already-sorted list, the list is expected to be short. The additional complexity was determined to unnecessary at this time. This also fixes a bug where path IDs were not added to `retired_path_ids` after `retired.insert()` returned an error.
LPardue
force-pushed
the
dcid-retire-partition
branch
from
41d5541 to
5a70b58
Compare
LPardue
changed the title
LPardue
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dcidsConnectionIdVecDeque is not guaranteed to be sorted, soplainly applying
self.dcids.inner.partition_point(...)can lead toincorrect result. While we could introduce such a guarantee, it would
require spending more cycles when handling out-of-order sequence numbers.
Instead, this change checks all elements in O(n) time. While it is
possible to optimize further to take advantage of an already-sorted
list, the list is expected to be short. The additional complexity was
determined to unnecessary at this time.
This also fixes a bug where path IDs were not added to
retired_path_idsafterretired.insert()returned an error.