qlog: Add RESET_STREAM_AT#2520
Open
martinthomson wants to merge 1 commit into
Open
Conversation
This minimally adds the definition of the frame from https://quicwg.org/reliable-stream-reset/draft-ietf-quic-reliable-stream-reset.html
LPardue
reviewed
Jun 25, 2026
| ResetStreamAt { | ||
| stream_id: u64, | ||
| error: ApplicationError, | ||
| error_code: Option<u64>, |
Contributor
There was a problem hiding this comment.
This is inconsistent with the definition in the editor's copy https://quicwg.org/qlog/draft-ietf-quic-qlog-quic-events.html#section-8.13.5 where the field is error_code_bytes.
It smells like the spec is using an inconsistent field name with https://quicwg.org/qlog/draft-ietf-quic-qlog-quic-events.html#section-8.13.4, rather than your PR being wrong. However, we should ensure the spec is updated before we cut draft 13 (that would introduce reset_stream_at)
Contributor
|
Tests?! 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minimally adds the definition of the frame from https://quicwg.org/reliable-stream-reset/draft-ietf-quic-reliable-stream-reset.html
I couldn't see any tests for this stuff, so I'm assuming that this is all that is needed.