Skip to content

Fix qlog-dancer wasm chart coordinate types#2522

Open
snvtac wants to merge 1 commit into
cloudflare:masterfrom
snvtac:snvtac/2519-qlog-dancer-wasm-type-mismatch
Open

Fix qlog-dancer wasm chart coordinate types#2522
snvtac wants to merge 1 commit into
cloudflare:masterfrom
snvtac:snvtac/2519-qlog-dancer-wasm-type-mismatch

Conversation

@snvtac

@snvtac snvtac commented Jun 26, 2026

Copy link
Copy Markdown

Fixes #2519.

Summary

  • align qlog-dancer wasm draw range parameters with ClampParams' f64 start/end values
  • add chart metadata helpers for f64-backed plotter axes
  • store wasm chart info using the actual chart coordinate types, including packet delta as u64/f64

Validation

  • cargo +nightly fmt -- --check
  • cargo +nightly check -p qlog-dancer --target wasm32-unknown-unknown --lib
  • wasm-pack build --target=web
  • cargo +nightly check -p qlog-dancer --all-targets
  • cargo +nightly clippy -p qlog-dancer --all-targets -- -D warnings

@snvtac snvtac requested a review from a team as a code owner June 26, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

qlog-dancer: wasm build fails to compile (f32/f64 type mismatches in web.rs)

1 participant