Remove deprecated Doppler recentLogs for 6.x#1350
Open
jorbaum wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Added a PR to fix the regression: #1352 |
jorbaum
force-pushed
the
issue-1181-remove-recentlogs
branch
from
e3ecba3 to
3731bde
Compare
Remove DopplerClient.recentLogs(), RecentLogsRequest, Applications.logs(LogsRequest), and LogsRequest — all deprecated in 5.x (cloudfoundry#1348). Inline the Doppler streaming path directly into logs(ApplicationLogsRequest). Update README with breaking changes.
jorbaum
force-pushed
the
issue-1181-remove-recentlogs
branch
from
3731bde to
0648948
Compare
Contributor
Author
|
Rebased and made sure the regression still has been fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #1181 / #1348.
DopplerClient.recentLogs(),RecentLogsRequest,Applications.logs(LogsRequest), andLogsRequest- deprecated in 5.x (feat: Replace deprecated Doppler recentLogs with Log Cache client 5.X.X #1348)UnsupportedOperationExceptionfor deprecatedlogs()withrecent==trueNote on default behavior
With recent changes in #1348
logs(ApplicationLogsRequest)defaults torecent=true(LogCache) whenrecentis null. This differs fromlogs(LogsRequest), where null defaulted torecent=false(Doppler streaming).