build: add modrot dependency-archival audit target#5683
Merged
norman-abramovitz merged 2 commits intoJul 23, 2026
Conversation
Add `make audit modrot`, a report-only scanner that runs modrot over the backend go.mods (jetstream + api + every plugin module, one recursive pass) to flag archived and deprecated GitHub dependencies. Wired through the same register/WANT/FLAG machinery as the other audit modifiers, plus the no-op target and KNOWN_MODS entry. It needs `gh auth token` + network (GitHub GraphQL), so it is a standalone extra and is NOT part of the default `make audit` set.
norman-abramovitz
approved these changes
Jul 23, 2026
norman-abramovitz
left a comment
norman-abramovitz
left a comment
Contributor
There was a problem hiding this comment.
LGTM - modrot will be updated later to provide go.mod line numbers and and SARIF output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
make audit modrot, a new report-only scanner in theauditfamily. Itruns modrot recursively over
the backend go.mods —
src/jetstream,src/jetstream/api, and every pluginmodule — in a single pass, flagging archived and deprecated GitHub
dependencies (a supply-chain rot signal the existing vuln scanners don't
cover).
Details
|| true), gated onwhich modrot, matching every othermake audittarget.no-op target list, and
KNOWN_MODS, plus the header andmake helplines.make auditset: modrot needsgh auth token+network (GitHub GraphQL), which the offline default scanners don't. It's a
standalone extra, like
tree/history/licenses.--recursive --deprecated --resolve(archived and deprecated deps;--resolvemaps vanity imports likegoogle.golang.org/grpcto theirGitHub repo so they're actually checked).
CI wiring (a token + the shared tools image) is deferred to the pipeline work;
this PR adds the make target only, runnable locally today.
Verification
make audit modrotruns clean and reports (found archived deps incl.golang/mock,mitchellh/mapstructure).make audit(default) excludes it;make audit backend modrotcomposes correctly; no parse warnings.