Conversation
UAA no longer uses the Gradle Cargo plugin for local test runs. Use the gradlew "run" task (kills any stale UAA process, then bootRun) to start it and UAA's own scripts/kill_uaa.sh to stop it. startUAA.sh now backgrounds the boot process since bootRun blocks in the foreground, unlike the old Cargo deploy task. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the UAA test harness to work with current UAA Gradle tasks by replacing the removed Cargo plugin tasks with UAA’s own run/kill mechanisms, so npm run start-uaa / npm run stop-uaa function again.
Changes:
- Switch
test/startUAA.shfromcargoStartLocalto a backgrounded./gradlew run. - Update
stop-uaanpm script to use UAA’s./scripts/kill_uaa.shinstead ofcargoStopLocal.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/startUAA.sh |
Starts UAA via Gradle run in the background so the script can continue to readiness polling and client setup. |
package.json |
Updates npm scripts to stop UAA via UAA’s kill script now that Cargo tasks are gone. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| cd test/tmp/uaa | ||
| ./gradlew cargoStartLocal 2>&1 > /dev/null | ||
| ./gradlew run 2>&1 > /dev/null & |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run start-uaa/npm run stop-uaawere broken:cargoStartLocal/cargoStopLocalno longer exist.test/startUAA.sh: replace./gradlew cargoStartLocalwith./gradlew run &. UAA'sruntask kills any stale UAA process then runsbootRun. It's backgrounded because, unlike the old Cargo deploy task,bootRunblocks in the foreground until killed — without&the script would hang before ever reaching the readiness poll / test-client creation.package.json: replacestop-uaa's./gradlew cargoStopLocalwith UAA's own./scripts/kill_uaa.sh, which looks up theUaaBootApplicationprocess viajps(falling back to killing whatever's on port 8080).Test plan
npm run start-uaa— UAA boots, OAuth token fetched,singular-test-clientcreatednpm run start-singular-app— static bundle servednpm run unit-test— 25 specs, 0 failuresnpm run integration-test(Nightwatch) — 56/56 assertions passed (Access Tests + Identity Tests)npm run stop-uaa/stop-singular-app— both processes cleaned up correctly🤖 Generated with Claude Code