S3 Version and Metadata support - #91
Merged
Merged
Conversation
Owner
|
Nice. Thanks, @matthiasbaldi! There are conflicts because I merged another PR first. Sorry about that! Could you rebase, please? Then I'll merge it. |
Review polish before contributing both features upstream: - don't show the versions-unavailable warning for empty buckets - keep all versions of an object together when sorting and paginating, and count objects (not versions) for pagination - only offer version-aware actions (Download, Metadata) on old-version rows; key-level actions like Delete operate on the latest version - ignore the versionId download parameter when SHOW_VERSIONS is disabled - return lastModified as RFC3339 from the metadata endpoint and format it client-side - document the metadata feature in the README and extend test coverage Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
SHOW_METADATA (default true) gates both the "Metadata" object action in the bucket view and the /metadata endpoint registration, mirroring how ALLOW_DELETE gates its UI action and routes. Setting it to false hides the action and returns 404 for the metadata endpoint. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
@cloudlena should be fixed. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings two new core features to the s3manager:
Therefore we have two new configuration parameters:
Currently tested with alternative S3 providers, not yet tested with AWS.