chore: add comment to deploying fork prs - #127
Merged
Merged
Conversation
amanabiy
force-pushed
the
chore/add-comment-deploy-fork-prs
branch
from
July 27, 2026 01:18
cb9d8f2 to
37f3e54
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds clarifying inline documentation to the preview deployment workflows, focusing on how fork PR previews are built without secrets and then deployed via a privileged workflow_run-based handoff.
Changes:
- Document the fork preview deployment flow and its security constraints in
deploy-fork-preview.yml. - Add an inline note in
deploy.ymlclarifying that the workflow is intended for internal PRs (same-repo) rather than forks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/deploy.yml | Adds a note describing that this deploy path is for internal PRs (same repo) only. |
| .github/workflows/deploy-fork-preview.yml | Adds detailed comments describing the fork preview build/deploy handoff and why the privileged workflow must not execute fork code. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jperals
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds inline comments documenting the fork preview deployment flow, including maintainer approval, the unprivileged build-lint-test.yml build, the workflow_run handoff, and the privileged artifact-only deployment.
No workflow behavior changes.
Follow up of #122
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.