Skip to content

chore: import HighchartsReact directly instead of default export #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jperals wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: import HighchartsReact directly instead of default export #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6ca395
chore: import HighchartsReact directly instead of default export
jperals Jul 28, 2026
ef9fda1
Refactor tests as well
jperals Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/__tests__/chart-core-axes.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@

import type Highcharts from "highcharts";
import highcharts from "highcharts";
import HighchartsReact from "highcharts-react-official";
import { HighchartsReact } from "highcharts-react-official";
import { vi } from "vitest";

import testClasses from "../../../lib/components/core/test-classes/styles.selectors";
import { objectContainingDeep, renderChart } from "./common";

vi.mock("highcharts-react-official", () => ({ __esModule: true, default: vi.fn(() => null) }));
vi.mock("highcharts-react-official", () => ({ HighchartsReact: vi.fn(() => null) }));

const series: Highcharts.SeriesOptionsType[] = [
{ type: "line", name: "Line 1", data: [1, 2, 3] },
Expand Down
4 changes: 2 additions & 2 deletions src/core/__tests__/chart-core-fit-size.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { useEffect, useRef } from "react";
import { render as rtlRender, waitFor } from "@testing-library/react";
import highcharts from "highcharts";
import HighchartsReact from "highcharts-react-official";
import { HighchartsReact } from "highcharts-react-official";
import { vi } from "vitest";

import { circleIndex } from "@cloudscape-design/component-toolkit/internal";
Expand All @@ -13,7 +13,7 @@ import { ChartContainer } from "../../../lib/components/core/chart-container";
import testClasses from "../../../lib/components/core/test-classes/styles.selectors";
import { objectContainingDeep, renderChart } from "./common";

vi.mock("highcharts-react-official", () => ({ __esModule: true, default: vi.fn(() => null) }));
vi.mock("highcharts-react-official", () => ({ HighchartsReact: vi.fn(() => null) }));

// In chart container we use three container queries, that run in the following order: chart, header, footer.
let queryMeasurementIndex = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/core/__tests__/chart-core-options.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@

import type Highcharts from "highcharts";
import highcharts from "highcharts";
import HighchartsReact from "highcharts-react-official";
import { HighchartsReact } from "highcharts-react-official";
import { vi } from "vitest";

import { CoreChartProps } from "../../../lib/components/core/interfaces";
import { objectContainingDeep, renderChart } from "./common";
import { ChartRendererStub } from "./highcharts-utils";

vi.mock("highcharts-react-official", () => ({ __esModule: true, default: vi.fn(() => null) }));
vi.mock("highcharts-react-official", () => ({ HighchartsReact: vi.fn(() => null) }));

const rendererStub = new ChartRendererStub();
const chartStub = {
Expand Down
2 changes: 1 addition & 1 deletion src/core/chart-core.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { useEffect, useRef } from "react";
import clsx from "clsx";
import type Highcharts from "highcharts";
import HighchartsReact from "highcharts-react-official";
import { HighchartsReact } from "highcharts-react-official";

import {
getIsRtl,
Expand Down
Loading