chore: Use getOptionalElementWidth in top navigation for better type safety - #4836
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Top Navigation sizing measurements to use the existing getOptionalElementWidth helper when reading widths of the search utility and overflow menu trigger, improving type safety and avoiding unsafe non-null assertions in DOM querying.
Changes:
- Replaced direct
querySelector(... )!.getBoundingClientRect().widthcalls withgetOptionalElementWidth(...)for optional utility elements. - Ensures missing elements are handled consistently by returning
0rather than throwing at runtime.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4836 +/- ##
=======================================
Coverage 97.62% 97.62%
=======================================
Files 956 956
Lines 31012 31012
Branches 11410 11410
=======================================
Hits 30277 30277
Misses 688 688
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jperals
enabled auto-merge
July 27, 2026 11:13
avinashbot
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ticket:
AWSUI-62169How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.