Skip to content

chore: Use getOptionalElementWidth in top navigation for better type safety - #4836

Merged
jperals merged 1 commit into
mainfrom
chore/top-navigation-optional-wdth
Jul 27, 2026
Merged

chore: Use getOptionalElementWidth in top navigation for better type safety#4836
jperals merged 1 commit into
mainfrom
chore/top-navigation-optional-wdth

Conversation

@jperals

@jperals jperals commented Jul 27, 2026

Copy link
Copy Markdown
Member

Description

Ticket: AWSUI-62169

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Top Navigation sizing measurements to use the existing getOptionalElementWidth helper when reading widths of the search utility and overflow menu trigger, improving type safety and avoiding unsafe non-null assertions in DOM querying.

Changes:

  • Replaced direct querySelector(... )!.getBoundingClientRect().width calls with getOptionalElementWidth(...) for optional utility elements.
  • Ensures missing elements are handled consistently by returning 0 rather than throwing at runtime.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.62%. Comparing base (ee9b849) to head (20260a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4836   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files         956      956           
  Lines       31012    31012           
  Branches    11410    11410           
=======================================
  Hits        30277    30277           
  Misses        688      688           
  Partials       47       47           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals
jperals enabled auto-merge July 27, 2026 11:13
@jperals
jperals added this pull request to the merge queue Jul 27, 2026
Merged via the queue into main with commit 71ba335 Jul 27, 2026
60 checks passed
@jperals
jperals deleted the chore/top-navigation-optional-wdth branch July 27, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants