Skip to content

Update installation instructions for conda-forge, add JOSS draft - #44

Closed
chrisjonesBSU wants to merge 107 commits into
cmelab:mainfrom
chrisjonesBSU:joss
Closed

Update installation instructions for conda-forge, add JOSS draft#44
chrisjonesBSU wants to merge 107 commits into
cmelab:mainfrom
chrisjonesBSU:joss

Conversation

@chrisjonesBSU

Copy link
Copy Markdown
Member

No description provided.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Comment thread msibi/forces.py
if self.smoothing_order is None:
self.smoothing_order = 2
if self.correction_fit_window is None:
self.correction_fit_window = 10

Check warning

Code scanning / CodeQL

Overwriting attribute in super-class or sub-class Warning

Assignment overwrites attribute correction_fit_window, which was previously defined in superclass
Force
.
Comment thread msibi/forces.py
if self.smoothing_order is None:
self.smoothing_order = 4
if self.correction_fit_window is None:
self.correction_fit_window = 8

Check warning

Code scanning / CodeQL

Overwriting attribute in super-class or sub-class Warning

Assignment overwrites attribute correction_fit_window, which was previously defined in superclass
Force
.
try:
avg = (V[idx + start - 1] + V[idx + start + 1]) / 2
V[idx + start] = avg
except IndexError:

Check notice

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.
@chrisjonesBSU

Copy link
Copy Markdown
Member Author

Wrong upstream selected :)

@codecov

codecov Bot commented Sep 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.21569% with 88 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@fe2bd54). Learn more about missing BASE report.

Files with missing lines Patch % Lines
msibi/forces.py 85.91% 51 Missing ⚠️
msibi/utils/conversion.py 86.53% 21 Missing ⚠️
msibi/state.py 91.56% 7 Missing ⚠️
msibi/optimize.py 94.39% 6 Missing ⚠️
msibi/utils/corrections.py 95.77% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage        ?   89.34%           
=======================================
  Files           ?       10           
  Lines           ?      826           
  Branches        ?        0           
=======================================
  Hits            ?      738           
  Misses          ?       88           
  Partials        ?        0           
Files with missing lines Coverage Δ
msibi/__init__.py 100.00% <100.00%> (ø)
msibi/__version__.py 100.00% <100.00%> (ø)
msibi/utils/exceptions.py 100.00% <100.00%> (ø)
msibi/utils/general.py 100.00% <100.00%> (ø)
msibi/utils/potentials.py 100.00% <100.00%> (ø)
msibi/utils/corrections.py 95.77% <95.77%> (ø)
msibi/optimize.py 94.49% <94.39%> (ø)
msibi/state.py 91.95% <91.56%> (ø)
msibi/utils/conversion.py 86.53% <86.53%> (ø)
msibi/forces.py 85.91% <85.91%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants