Reuse preloaded participation and show N/A scores

Avoid a duplicate DB query by reusing a participation object that ContestHandler may have preloaded for sidebar scores; only call _load_participation_for_scores when necessary. Compute task scores conditionally as before. UI fixes: display "N/A" for undefined task scores in the contest sidebar, add CSS for the undefined badge state, and ensure task submission badges remove the undefined class and are shown after updating the score.

Author: pxsit

cms/server/contest/handlers/main.py

@@ -82,18 +82,26 @@ def render_params(self):
         ret = super().render_params()
 
         if self.current_user is not None:
-            participation = self._load_participation_for_scores(self.current_user)
-            if participation is None:
-                return ret
+            participation = ret["participation"]
 
-            self.contest = participation.contest
-            # Ensure the template sees this fully-loaded version.
-            ret["contest"] = self.contest
-            ret["participation"] = participation
-            ret["user"] = participation.user
-
-            # Compute public scores for all tasks only if they will be shown
+            # ContestHandler may have already loaded a fully-joined participation
+            # while computing sidebar scores. Reuse it to avoid a duplicate query.
+            already_preloaded_for_scores = "sidebar_task_scores" in ret
             if self.contest.show_task_scores_in_overview:
+                if not already_preloaded_for_scores:
+                    loaded_participation = self._load_participation_for_scores(
+                        participation
+                    )
+                    if loaded_participation is None:
+                        return ret
+                    participation = loaded_participation
+
+                    self.contest = participation.contest
+                    # Ensure the template sees this fully-loaded version.
+                    ret["contest"] = self.contest
+                    ret["participation"] = participation
+                    ret["user"] = participation.user
+
                 ret["task_scores"] = self._compute_task_scores(
                     participation,
                     actual_phase=ret["actual_phase"],

cms/server/contest/static/cws_style.css

@@ -473,6 +473,10 @@ td.token_rules p:last-child {
     color: #333;
     text-transform: none;
 }
+.nav-list .nav-header .task_score_badge.undefined {
+    color: #888;
+    background-color: transparent;
+}
 /*** Submit a solution */
 
 #submit_solution {

cms/server/contest/templates/contest.html

@@ -187,7 +187,7 @@ <h3 id="countdown_box">
                                     {{ sidebar_task_scores[t_iter.id][2] }}
                                 </span>
                 {% else %}
-                                <span class="task_score_badge task_score undefined"></span>
+                                <span class="task_score_badge task_score undefined">{% trans %}N/A{% endtrans %}</span>
                 {% endif %}
             {% endif %}
                             </li>

cms/server/contest/templates/task_submissions.html

@@ -132,9 +132,10 @@
         return;
     }
 
-    badge.removeClass('score_0 score_0_100 score_100');
+    badge.removeClass('undefined score_0 score_0_100 score_100');
     badge.addClass(get_score_class(task_score, max_score));
     badge.text(task_score_message);
+    badge.show();
 };
 
 update_scores = function (submission_id, data) {