Wrap correctionlib._core.CorrectionSet.from_string with an LRU cache - #349
Open
ikrommyd wants to merge 1 commit into
Open
Wrap correctionlib._core.CorrectionSet.from_string with an LRU cache#349ikrommyd wants to merge 1 commit into
correctionlib._core.CorrectionSet.from_string with an LRU cache#349ikrommyd wants to merge 1 commit into
Conversation
Signed-off-by: Iason Krommydas <iason.krom@gmail.com>
ikrommyd
changed the title
correctionlib._core.CorrectionSet.from_string with an LRU cache
nsmith-
reviewed
Jul 21, 2026
| return iter(self._base) | ||
|
|
||
|
|
||
| @lru_cache(maxsize=64) |
Collaborator
There was a problem hiding this comment.
This is pretty large size, which would increase the memory usage of the process a bit depending on the size of the correction set (some are 10s MB)
Contributor
Author
There was a problem hiding this comment.
What is the typical size of those strings? I thought they would be in the kBs so I thought 64 would be fine. What number would you suggest?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #347
This removed millions of allocations from HiggsDNA without even the systematics loop.