fix(config): add cross-process file locking and config.Modify to prev… - #11
Open
Adityakk9031 wants to merge 1 commit into
Open
fix(config): add cross-process file locking and config.Modify to prev…#11Adityakk9031 wants to merge 1 commit into
Adityakk9031 wants to merge 1 commit into
Conversation
…ent OAuth token clobbering (codag-megalith#8)
Author
|
@michaelzixizhou have a look |
1 similar comment
Author
|
@michaelzixizhou have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8.
Resolves a destructive race condition where concurrent processes (such as a long-running
codag mcp servesession running in parallel with CLI commands) execute whole-structconfig.Load-> mutate ->config.Savecycles, overwriting rotated OAuth refresh tokens with stale in-memory data and causing spurious user logouts.Root Cause
sync.Mutex(fileMu) only serialized goroutines within a single process instance, leaving concurrent OS processes un-synchronized.config.Save) wrote back stale token structs if loaded prior to a token rotation.singleflightdeduplication.Key Changes
flockon Unix /LockFileExon Windows) onconfig.json.lockininternal/config.config.ModifyAPI: Introducedconfig.Modify(func(cfg *Config) error)which re-loads the latest state under the file lock, applies only the specific caller's delta, and saves atomically.config.Modify.ensureAnonymousTokenwithsingleflight.Groupto prevent stampedes on initial run.TestModifyConcurrentDeltasinconfig_test.goto ensure concurrent delta writes retain rotated tokens and distinct fields.Verification