Fix/lesson 25 ci toby evans - #813
Open
tobyev wants to merge 7 commits into
Open
Conversation
…; POST uses CreateMediaItemRequest/Response with 201
…troller accepts Librarian
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made updates to my Lesson 25 homework by adding a SQL queries file (lesson25_toby_evans.sql) with the three required queries, creating a library_users table with seeded users, implementing LibraryUserModel and LibraryUserRepository, and wiring users into the LibraryDataModel via LibraryDbDataLoader .
I also corrected the "total pages checked out" query to join checked_out_items with media_items . My changes were staged, committed, pushed, and are ready for review on feat/lesson-25-hw-toby-evans (with follow-up fixes on fix/lesson-25-ci-toby-evans).
Problem area (s):
• Running Gradle from the wrong project path for Lesson 25
• SQLite "unable to open database file" from pointing at the wrong DB location
• Initial pages sum query missing a join to media_items
• sed insertion not matching return dataModel; in LibraryDbDataLoader
Lessons learned:
• Double-check module paths before running builds (lesson_25/db vs repo root)
• Verify the actual DB file and schema with SQLite before querying
• Use the correct JOINS for aggregate queries that reference fields in other tables
• Make small, testable commits and re-run checks after each change