Skip to content

Adding more BP topic types#180

Merged
Sanic merged 2 commits into
code-iai:masterfrom
phuicy:master
Sep 20, 2022
Merged

Adding more BP topic types#180
Sanic merged 2 commits into
code-iai:masterfrom
phuicy:master

Conversation

@phuicy

@phuicy phuicy commented Sep 10, 2022

Copy link
Copy Markdown
Contributor

I have implemented more of the BP features.

image

I will do more. But this is what I need for the moment.

@Sanic

Sanic commented Sep 20, 2022

Copy link
Copy Markdown
Contributor

Hi @phuicy
Thank you very much for the BP. Adding types is always highly appreciated.
Based on the title of your PR, i wondered about the changes in the ROSIntegrationGameInstance and the TCPConnection core functionality.
What is the rationale behind these changes?

/edit: Ah, i see now. This is basically the same changes as in #181 , right ?

@phuicy

phuicy commented Sep 20, 2022

Copy link
Copy Markdown
Contributor Author

Sorry yes, commit: 7798308 was meant to be cherry picked out for #181.

I will remove that from this branch now.

@phuicy

phuicy commented Sep 20, 2022

Copy link
Copy Markdown
Contributor Author

@Sanic Resolved.

@Sanic

Sanic commented Sep 20, 2022

Copy link
Copy Markdown
Contributor

@phuicy Great! Thank you very much.

@Sanic Sanic merged commit c0914fb into code-iai:master Sep 20, 2022
@tsender

tsender commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

@phuicy How did you get this to compile? I'm using UE4.26 and I get a compile error saying "Type 'double' is not supported by blueprint." from the void OnFloat64Message(const double& Data) function you added in RI/Topic.h. I'm guessing you're using UE5?

I've tried putting the UFUNCTION inside a preprocessor directive that checks to see if we are using UE5, but UE does not allow UFUNCTIONS to be placed inside preprocessor directives. I'm thinking we need to remove the OnFloat64Message function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants