fix(compaction): stabilize request-local reduction cache - #901
Open
codeg-dev wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f11d2061f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_compactevent.The context hook rewrites only the outgoing request; it does not replace stored session history. With a stateless gate, reported usage moving from 501,000 to 499,000 tokens against a one-million-token window alternated reduced and unreduced payload shapes for the same stored history. This change keeps the request shape stable until compaction actually changes that history.
The stateful high/low watermark introduced for emergency pruning in #425 is the closest precedent. Here, an accepted compaction is the release condition because a narrow numeric release band cannot prove that stored history changed.
Fixes #900.
Tests
npm run checknpm run buildSummary by cubic
Stabilizes request-local context reduction by latching once the 50% gate is crossed and releasing only after an accepted, persisted compaction or when session-tree navigation changes the active branch. Previously reduction flipped around 50%, producing alternating payload shapes; now requests keep one reduced shape until history actually changes.
ContextReductionLatchwithcreateContextReductionLatchandresetContextReductionLatch;shouldApplyContextReductionoptionally accepts a latch. Stateless callers are unchanged; pass a latch to keep stable reduction across requests.session_compactand onsession_treenavigation; rejected compaction does not reset. Preserves provider-native compaction bypass while latched.packages/coding-agent/src/core/extensions/builtin/compaction/context-reduction.tsandpackages/coding-agent/src/core/extensions/builtin/compaction/index.ts.Written for commit 231d467. Summary will update on new commits.