Skip to content

Exposed coveralls token #2

Description

@dsernst

https://github.com/codedoctor/hapi-loggly/blob/master/Gruntfile.coffee#L41 exposes your coveralls token, which is meant to be kept secret. Not the biggest issue in the world — worst case is a bad actor makes your coverage say 0% — but still not ideal.

Better approach is use an environment variable.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions