DistributionMgmt->Site->URL incorrectly set for site:stage

[kwin]

The distributionMgmt site URL in

plexus-pom/pom.xml

Line 328 in 393099c

<url>${project.scm.developerConnection}</url>

is pointing to a Git URL, e.g. scm:git:git@github.com:codehaus-plexus/plexus-sec-dispatcher.git (from https://github.com/codehaus-plexus/plexus-sec-dispatcher/blob/35804938db2feec87fabe24d75509cd0d8dc3c47/pom.xml#L20). However this value is evaluated for site:stage (https://maven.apache.org/plugins/maven-site-plugin/stage-mojo.html) to calculate the folder structure being created below target/staging (for multimodule sites).

By default the same value is also used by maven-scm-publish-plugin in https://maven.apache.org/plugins/maven-scm-publish-plugin/publish-scm-mojo.html#pubScmUrl. However this is already overwritten in

plexus-pom/pom.xml

Line 534 in 393099c

<pubScmUrl>${project.scm.developerConnection}</pubScmUrl>

. Therefore the distributionManagement.site.url should rather point to the HTTP URL of where the site is hosted!

[kwin]

@michael-o IMHO this is a bug in the maven-site-plugin, WDYT?

[michael-o]

@michael-o IMHO this is a bug in the maven-site-plugin, WDYT?

Honestly, no.idea from the top.of.my head.

[kwin]

I created https://issues.apache.org/jira/browse/MSITE-1032 for this.

[slawekjaranowski]

very strange ... last time when I released parent I don't have a problem
It is a bug only for multimodule site?

[kwin]

The other way around, only affects single module repos. There site:stage does not work correctly

[slawekjaranowski]

if you set:

  <distributionManagement>
    <site>
      <id>github:gh-pages</id>
      <url>${project.scm.url}</url>
    </site>
  </distributionManagement>

in plexus-sec-dispatcher stage will be ok ... magic 😄

[slawekjaranowski]

I would like to release a plexus-pom, and next plexus-languages - with JDK 24 support

Tested locally and looks ok.

Do you have any objections?

[kwin]

if you set:

  <distributionManagement>
    <site>
      <id>github:gh-pages</id>
      <url>${project.scm.url}</url>
    </site>
  </distributionManagement>

in plexus-sec-dispatcher stage will be ok ... magic 😄

This will break maven-scm-publish-plugin leveraging that element as well. Also I consider this a workaround to say the least..

[kwin]

No objections to a release though. Not sure yet how to fix this issue (if at all in the parent)

[kwin]

Requires apache/maven-site-plugin#1159.

[slachiewicz]

Why do we have issues here only for Plexus repos and plexus parent but not for ASF projects? What is configured differently?

[kwin]

ASF projects use SVN based sites while plexus uses Git based ones.

[slachiewicz]

Reproduced on plexus 27, released yesterday, with a note on which repos it reaches.

Single module. plexus-xml, mvn -Preporting verify site site:stage: staging resolves to target/staging/../plexus-xml.git, so target/staging ends up empty while target/site holds 217 files.

Multi-module. plexus-languages, same command: target/staging gets 251 files. Staging is correct there.

So the breakage is confined to single-module repositories, and it stays invisible because RELEASING.md tells people to publish those with site-deploy, which never invokes site:stage. The multi-module command that does invoke it works.

On whether the element can be changed: 27 sets <pubScmUrl>${project.scm.developerConnection}</pubScmUrl> in pluginManagement, with the comment "using scm.developerConnection instead of distributionManagement.site.url". maven-scm-publish-plugin therefore does not read distributionManagement/site/url in this parent, and pointing that element at the hosted HTTP URL — as the issue description proposes — would leave publishing untouched.

apache/maven-site-plugin#1159 is still open, and 27 already carries site plugin 3.22.0, the newest release.

This comment was created with AI assistance.