feat(icp): add chat-based ICP creation and edit interface - #16
Open
Rishavraaj wants to merge 3 commits into
Open
feat(icp): add chat-based ICP creation and edit interface#16Rishavraaj wants to merge 3 commits into
Rishavraaj wants to merge 3 commits into
Conversation
Rishavraaj
force-pushed
the
feat/icp-chat-interface
branch
2 times, most recently
from
July 27, 2026 07:47
97a1322 to
923c866
Compare
- Add IcpChat component with state machine (description → compile → confirm → name → create) - Add /icps/new page using chat flow instead of form sheet - Add /icps/:id/edit page for editing via chat (starts at awaiting_confirm with existing filters) - Edit button in profile sidebar navigates to /icps/:id/edit instead of opening sheet - Show all filters (organizationName, excludeLocations, personTitles, personSeniorities, technologiesAnyOf) in profile detail panel - Remove contact DB sync; serve contacts live from Apollo (free endpoint) - Remove RunIcpButton and POST /:id/run endpoint - Use LLM (gpt-4o-mini) to classify confirm vs refine intent instead of keyword matching - Add POST /icps/refine-filters endpoint: passes current filters as context so refinements merge instead of replacing existing filters - Fix contacts search: map locations → organization_locations (not person_locations), add organizationName and excludeLocations to payload Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rishavraaj
force-pushed
the
feat/icp-chat-interface
branch
from
July 27, 2026 07:53
923c866 to
d4f044e
Compare
…alidation - Add POST /icps/preview-filters (no profile ID) so new-ICP chat can preview Apollo counts before a profile exists; old /:id/preview-filters kept for edit mode - Extract shared runPreview() helper in IcpService - Add ClassifyIntentDto (MinLength 1) so short replies like "yes" pass validation on classify-intent (was failing with MinLength 10) - Frontend: previewFilters() accepts id|undefined, routes to anon endpoint when no profile; drop ?? 1 fallback Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Prevents full page reloads on back button and internal links. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before this PR, creating or editing an ICP profile used a form sheet with dropdowns. It was rigid — you had to know exactly what filters to pick. Now you just describe your ideal customer in plain English and AI builds the filters for you.
Editing works the same way — the Edit button now opens the same chat, but pre-loaded with existing filters. You can say "add Bengaluru" or "also target VPs" and it merges your change in without losing anything.
Changes
New chat interface
IcpChatcomponent — a chat window that walks you through describing your ICP, reviewing filters, and saving the profile/icps/new— new page that opens the chat for creating a profile/icps/:id/edit— new page that opens the chat pre-filled with existing filters for editingSmarter filter refinement
Profile detail panel
Removed contact DB sync
Fixed Apollo search bugs
person_locations→organization_locations)Test plan
/icps/new, describe an ICP, confirm filters, name it, verify profile is created and you land on the profile page