feat(icp): Make ICP details only scrollable - #22
Merged
Conversation
The ICP detail page previously relied on whole-document scroll, so long Notes content dragged the header, tabs, and filters sidebar out of view. Bound the tab-content row to the viewport height and give the notes column and filters sidebar their own independent overflow-y-auto scroll, with the header and the "Notes" label pinned via sticky positioning. Also reserves a left-side gutter (-ml-20/pl-20) on the scrollable column so EditorJS's block toolbar (+/drag-handle icons, which render slightly outside the block's own box) isn't clipped by the new overflow container. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Rishavraaj
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
apps/web/src/components/Icp/IcpDetail.tsx):shrink-0flex child above amin-h-0 flex-1content row, with the notes column and filters sidebar each set toself-stretch overflow-y-auto.DetailsPanel's "Notes" label + saving indicatorsticky top-0within the scroll container.-ml-20/pl-20) on the scrollable notes column so EditorJS's block toolbar (+/drag-handle icons, which render slightly outside the block's own box) isn't clipped by the new overflow container.Test plan
window.scrollYstays0(no page-level scroll) while the inner container'sscrollTopmoves.+/drag-handle toolbar renders fully (not clipped) and is clickable after the scroll-container change.tsc --noEmitpasses with no errors in the changed file.🤖 Generated with Claude Code