Remove description field from ICP create/edit form - #23
Closed
anujeet98 wants to merge 1 commit into
Closed
Conversation
The ICP detail page already has its own Notes editor + "Compile Filters from Notes" flow, which both forms' description editor already fell back to reading. The drawer's separate Description field was redundant UI with no compile action of its own, so drop it and let the detail page's Notes editor be the single place to write/edit description content and compile filters, without needing to open the form drawer. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IcpDetail.tsx'sDetailsPanel), driven by thenotesfield, with its own "Compile Filters from Notes" action and preview/apply flow. The create/edit form drawer (IcpForm.tsx) additionally had a standalone Description editor with no compile action of its own — redundant now that the detail page covers writing/editing description content and compiling filters directly.Changes
apps/web/src/components/Icp/IcpForm.tsx):Field/Editorblock, itsdescriptionstate, and thedescriptionpayload from both the create and update mutations.OutputData,Editor,ensureOutputData).descriptionDB column/DTOs are left as-is for backward compatibility;DetailsPanel/handleCompileinIcpDetail.tsxalready fall back toprofile.descriptionfor any pre-existing profiles that only have legacy description content and no notes yet.Test plan
tsc --noEmitpasses with no errors in the changed file.🤖 Generated with Claude Code