Skip to content

Remove description field from ICP create/edit form - #23

Closed
anujeet98 wants to merge 1 commit into
mainfrom
feat/move-icp-description-to-detail
Closed

Remove description field from ICP create/edit form#23
anujeet98 wants to merge 1 commit into
mainfrom
feat/move-icp-description-to-detail

Conversation

@anujeet98

Copy link
Copy Markdown
Member

Summary

  • The "Compile from Description" flow already lives on the ICP detail page (IcpDetail.tsx's DetailsPanel), driven by the notes field, with its own "Compile Filters from Notes" action and preview/apply flow. The create/edit form drawer (IcpForm.tsx) additionally had a standalone Description editor with no compile action of its own — redundant now that the detail page covers writing/editing description content and compiling filters directly.
  • Removed the Description field from the form drawer so users write/edit description content only from the ICP detail page.

Changes

  • Frontend (apps/web/src/components/Icp/IcpForm.tsx):
    • Removed the Description Field/Editor block, its description state, and the description payload from both the create and update mutations.
    • Removed now-unused imports (OutputData, Editor, ensureOutputData).
  • No backend changes — the description DB column/DTOs are left as-is for backward compatibility; DetailsPanel/handleCompile in IcpDetail.tsx already fall back to profile.description for any pre-existing profiles that only have legacy description content and no notes yet.

Test plan

  • Verified via Playwright against the local dev server: the "Description" label/editor no longer appears in either the create dialog or the edit drawer.
  • Confirmed the Details tab's Notes editor + Compile flow on the detail page is unaffected.
  • tsc --noEmit passes with no errors in the changed file.

🤖 Generated with Claude Code

The ICP detail page already has its own Notes editor + "Compile Filters
from Notes" flow, which both forms' description editor already fell
back to reading. The drawer's separate Description field was redundant
UI with no compile action of its own, so drop it and let the detail
page's Notes editor be the single place to write/edit description
content and compile filters, without needing to open the form drawer.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@anujeet98 anujeet98 changed the title Move ICP description to ICP detail editor (not form drawer) Remove description field from ICP create/edit form Aug 3, 2026
@anujeet98 anujeet98 closed this Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant