Support for BCSTM files in themes - #60
Merged
Merged
Conversation
Owner
|
Whats the performance like? I did test adding BCSTM support in the past but it would have clipping & slowdown in NTR mode (it also occurred in TWL mode to a lesser extent) since pre-calico DKA doesn't have proper threading like BlocksDS & newer Calico devkitarm does and Pico-Launcher's implementation relies on threading. |
Author
|
Decoding runs on the main loop without extra threads and buffers smoothly. Here's a demo on my DSi via an Ace3DS+ clone: PXL_20260918_012932116.TS-10mb.mp4Tested audio across various themes, and all of these work smoothly:
|
Owner
|
Thanks, tested it out and all looks good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Themes can now use
bgm.bcstmfor menu music: 3DS music files, mono or stereo, up to 48 kHz. Loop points stored in the file are used, so a track repeats past its intro instead of restarting.bgm.wavworks exactly as before, and plays when a theme has no usablebgm.bcstm.WAV handling moved into
wavsource.cpp, andthememusic.cppnow just picks the source and keeps the same buffering.Tested on a DSi using an Ace3DS+ and a DSpico.