fix: parse the full cloud API response envelope#406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unified
unpack_request_jsonhelper returned only$json['data'], but the callers each need a different key from the full response: search readssnippets/meta/available_filters,get_single_snippet_from_cloudreadssnippet, and the taxonomy fetches readdata. As a result community search returned zero results (covered by the failingCloud_API_Search_Test::test_returns_parsed_snippets_and_total) and single-snippet fetch hit a null dereference with no test covering it.The helper now returns the whole decoded array and each caller extracts the key it needs. This restores search, getsnippet, types, categories, and revision with one change.
Added tests for single-snippet and revision fetches, including the empty-response paths. All 30 cloud tests pass.
Search aligns back on the
snippetskey; the cloud-app side drops the duplicatedatafrom search/featured responses in a companion PR, so no further plugin change is required.