fix: featured snippets retrieval against the snippets-only cloud response#409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Featured snippets returned empty after the cloud-app dropped the redundant
dataalias from search/featured responses (nowsnippets-only).Cloud_API::get_featured_snippets()had its own inline parse requiringisset($json['data']), separate from the sharedunpack_request_json()helper, so it returned an emptyCloud_Snippetsoncedatawas gone.Changes
get_featured_snippets()now parses viaunpack_request_json()(the full envelope), matching the search path.Cloud_Snippetsreads snippets from thesnippetskey only; the legacydatafallback is removed.get_cloud_types/get_cloud_categories) are unchanged — those endpoints still returndata.Verification
phpunit --group cloud: 30/30 pass.