Popover component does not reposition on scroll or window resize#351
Open
quangtuanitmo18 wants to merge 5 commits intomainfrom
Open
Popover component does not reposition on scroll or window resize#351quangtuanitmo18 wants to merge 5 commits intomainfrom
quangtuanitmo18 wants to merge 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dobrunia
approved these changes
May 6, 2026
neSpecc
approved these changes
May 6, 2026
There was a problem hiding this comment.
Pull request overview
Fixes Popover detaching from its target by keeping its computed position in sync while the page (or scrollable containers) scrolls and while the window resizes, and corrects horizontal positioning for horizontally scrolled pages (Issue #350).
Changes:
- Recalculate popover position on scroll/resize using throttled event handlers.
- Persist last
align/widthconfiguration so repositioning can re-runmove()consistently. - Fix horizontal offset by including
window.scrollXin left/right alignment calculations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #350