Refactor to support modular routing - #40
Merged
Merged
Conversation
jhunzik
requested review from
a-asaad,
dcruver,
pelletier2017 and
rececoffin
September 12, 2025 21:33
jhunzik
force-pushed
the
modular-routing
branch
3 times, most recently
from
September 12, 2025 23:16
7b68c2c to
67963ee
Compare
jhunzik
force-pushed
the
modular-routing
branch
from
September 12, 2025 23:17
67963ee to
cbe4739
Compare
a-asaad
approved these changes
Sep 15, 2025
jhunzik
commented
Sep 15, 2025
Collaborator
Author
There was a problem hiding this comment.
❓ Does it make sense to rename the artifact (and the git tag) Since this app won't be just a webhook in the future?
webhook_v0.15.0 --> keip_v0.1.0
Collaborator
Author
There was a problem hiding this comment.
We talked about this offline and decided on renaming the artifact and associated directory to webapp. The version will be bumped to 0.16.0 instead of resetting to maintain continuity.
jhunzik
force-pushed
the
modular-routing
branch
from
September 15, 2025 20:30
472be7a to
11ab977
Compare
jhunzik
force-pushed
the
modular-routing
branch
from
September 15, 2025 20:38
11ab977 to
ffda92c
Compare
Collaborator
|
Can we update the description to replace |
rececoffin
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
This change reorganizes the projects to make creating modular routes easier. It renames the
webhookpython app towebappand adds a newroutesdirectory for building out more routes.