Add FXMacroData OHLCV provider - #578
Open
roberttidball wants to merge 3 commits into
Open
Conversation
Collaborator
|
Hey @roberttidball, it seems that your PR is still in draft mode. |
roberttidball
marked this pull request as ready for review
July 15, 2026 05:06
Author
|
Hi @MDUYN — thanks for the earlier look, and apologies for the slow follow-up. This PR was taken out of draft shortly after your comment, so it has been ready for review since then and may have dropped off your radar while still showing as a draft in your queue. No changes are outstanding on my side. Happy to rebase onto the current main or adjust anything if it has drifted since. |
Switches the base URL from the undocumented fxmacrodata.com/api/v1 alias to the published api.fxmacrodata.com/v1 host, so the client matches the public API reference.
Switches the base URL from the undocumented fxmacrodata.com/api/v1 alias to the published api.fxmacrodata.com/v1 host, so the client matches the public API reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a native
FXMacroDataOHLCVDataProviderfor daily FX reference-rate series from the FXMacroData REST API.The provider:
market="FXMACRODATA"with daily1ddata sourcesEURUSDandEUR/USDMarketCredential(market="FXMACRODATA", api_key="..."),FXMACRODATA_API_KEY, orFXMD_API_KEYValidation
python -m pytest tests\infrastructure\data_providers\test_fxmacrodata_ohlcv_data_provider.py -qpython -m compileall -q investing_algorithm_framework\infrastructure\data_providers\fxmacrodata.pygit diff --check