feat: add September Prime API endpoints and regenerate models - #6
Merged
Conversation
✅ Heimdall Review Status
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
cfluke-cb
force-pushed
the
cfluke/sep-update
branch
from
September 1, 2026 20:32
7baa0b1 to
317291a
Compare
rcbgr
previously requested changes
Sep 1, 2026
rcbgr
left a comment
rcbgr
left a comment
Contributor
There was a problem hiding this comment.
Can we add a decrypt helper too?
encrypted_credentials is encrypted with HKDF-SHA256 + AES-256-GCM using your secret_key.
this would need to tie into the signer feature
| * immediate expiry on approval. Cannot extend beyond the original key's expiry. | ||
| */ | ||
| @JsonProperty("duration_seconds") | ||
| private Long durationSeconds; |
Contributor
There was a problem hiding this comment.
do we need a long? what's the max value?
Contributor
Author
There was a problem hiding this comment.
that is consistent where seconds is used elsewhere in sdk
cb-heimdall
dismissed
rcbgr’s stale review
September 1, 2026 21:04
Approved review 5082835055 from rcbgr is now dismissed due to new commit. Re-request for approval.
rcbgr
reviewed
Sep 1, 2026
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| /** XMLiquidatedAsset provides per-asset detail for a liquidation */ | ||
| public class XMLiquidatedAsset { |
Contributor
There was a problem hiding this comment.
This should be XmlLiquidationAsset?
Contributor
Author
There was a problem hiding this comment.
its Cross Margin (XM) everywhere in docs
rcbgr
previously approved these changes
Sep 2, 2026
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
|
|
||
| /** XMLiquidatedAsset provides per-asset detail for a liquidation */ | ||
| public class XMLiquidatedAsset { |
| */ | ||
| public CoinbasePrimeCredentials toPrimeCredentials() throws CoinbaseClientException { | ||
| if (Utils.isNullOrEmpty(serviceAccountId)) { | ||
| return new CoinbasePrimeCredentials(accessKey, passphrase, secretKey); |
Contributor
There was a problem hiding this comment.
This secret key is encrypted?
rcbgr
self-requested a review
September 2, 2026 15:27
rcbgr
previously approved these changes
Sep 2, 2026
rcbgr
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Syncs the Java SDK to the latest Coinbase Prime OpenAPI spec and exposes the new operations.
ApiKeyService.rotateApiKey(POST /api-keys/rotate).isBuyExacton create-order and order-preview request/response types (generatedOrderalready included it).Type of Change
OpenAPI Generator in
tools/model-generatoris bumped from 7.14.0 to 7.25.0.Checklist
Test plan
mvn -B test -DskipITs(unit/serialization tests)make formatwith JDK 17 (google-java-format 1.24.0 does not run on JDK 24+)GetConversionFees, XM liquidations, rewards rate, derivatives endpointsRotateApiKeyagainst a production key unless rotation is intendedMade with Cursor