Skip to content

Caspar: Raise error on unsupported multi-camera rig#4380

Draft
tordnat wants to merge 3 commits into
colmap:mainfrom
tordnat:tordnat/caspar-throw-error-on-unsupported-rig
Draft

Caspar: Raise error on unsupported multi-camera rig#4380
tordnat wants to merge 3 commits into
colmap:mainfrom
tordnat:tordnat/caspar-throw-error-on-unsupported-rig

Conversation

@tordnat
Copy link
Copy Markdown
Contributor

@tordnat tordnat commented May 6, 2026

Address #4376

@tordnat tordnat changed the title Caspra: Raise error on unsupported multi-camera rig Caspar: Raise error on unsupported multi-camera rig May 6, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the error handling in the CasparBundleAdjuster by changing a warning log to a fatal exception when encountering a non-ref rig camera with a variable pose. The reviewer pointed out that the log message should be updated to remove the phrase "Observations skipped," as it is misleading now that the process terminates instead of continuing.

Comment thread src/colmap/estimators/bundle_adjustment_caspar.cc Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@B1ueber2y
Copy link
Copy Markdown
Contributor

B1ueber2y commented May 6, 2026

Similarly applied to the other warnings in the implementation like https://github.com/colmap/colmap/blob/main/src/colmap/estimators/bundle_adjustment_caspar.cc#L247, where I think we should also throw.

Thanks. Can you also address this?

@B1ueber2y
Copy link
Copy Markdown
Contributor

Not sure if there are other such cases.

Comment thread src/colmap/estimators/bundle_adjustment_caspar.cc
@tordnat tordnat marked this pull request as draft May 6, 2026 12:05
@tordnat tordnat marked this pull request as draft May 6, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants