Skip to content

feat: allow secrets as source for auth identity/secret - #37

Merged
CRThaze merged 1 commit into
comet-ml:mainfrom
FreakIsTea:main
Sep 23, 2026
Merged

CRThaze merged 1 commit into
comet-ml:mainfrom
FreakIsTea:main

Conversation

@FreakIsTea

Copy link
Copy Markdown
Contributor

Disclaimer: This change has been implemented with AI-assistance

Right now, there's no way to configure auth.identity and auth.secret with an existing secret, making it impossible to keep secret values out of a gitops repository. This change allows for using a secret with a similar approach to the backends.*.existingSecret to keep it consistent.

@CRThaze CRThaze left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good contribution. Thanks.

CI failure is due to minio deleting their images. Not related to this change.

@CRThaze
CRThaze merged commit ad30827 into comet-ml:main Sep 23, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants