Skip to content

fix: don't count failing phase as completed in dax benchmark #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeyGarrison merged 1 commit into from
Jul 17, 2026
Merged

fix: don't count failing phase as completed in dax benchmark #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/sandbox/dax.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,10 @@ if (result.error) {

// Count completed phases
const phaseKeys = ['prepare', 'cache_clear', 'bun_download', 'bun_unpack', 'clone', 'install', 'typecheck'];
const phasesCompleted = phaseKeys.filter(k => phases[k] !== undefined).length;
const rawPhasesCompleted = phaseKeys.filter(k => phases[k] !== undefined).length;
// The script's phase() function emits BENCH_PHASE even for the failing phase (it prints timing before checking exit code).
// When there's an error, the last phase that emitted a BENCH_PHASE line is the one that failed, so don't count it.
const phasesCompleted = benchError ? Math.max(0, rawPhasesCompleted - 1) : rawPhasesCompleted;

// If no phases completed, the script didn't actually run (e.g. curl missing)
if (phasesCompleted === 0 && !benchError) {
Expand Down
Loading