feat(remix): add styler field metadata, raise Mix floor to 2.2.0-beta.5 - #158
Merged
Conversation
Point workspace Mix at conceptadev/mix#1031 so GridBox implicit rows size to content. Replace the overview Wrap/LayoutBuilder forks and drop hardcoded chart-card row heights.
space8 is 48px, not 32. The original page used 32 (space6); the larger padding dropped the chart Grid under its 1119 breakpoint at 1440.
mix#1031 (content-sized GridBox rows) and mix#1025 have shipped, so both dependency_overrides can go and the workspace resolves hosted Mix again. This unblocks tool/check_consumer_mix.dart, which was failing CI on "mix expected hosted, found git" for remix and remix_fortal. The two bumps are coupled and cannot land separately: mix_generator 2.2.0-beta.3 emits `implements StylerFieldMetadata` on every styler, and that symbol first ships in mix 2.2.0-beta.5. Regenerating against the new generator while remix still declared ^2.2.0-beta.4 would compile in this workspace and break any consumer that resolved beta.4, so the mix floor moves to beta.5 in the same commit as the 28 regenerated remix artifacts.
leoafarias
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Point workspace Mix at conceptadev/mix#1031 (
feat/grid-auto-rows) soGridBoximplicit rows size to content. The Fortal dashboard then drops hardcoded card-height tracks and the overviewWrap/LayoutBuilderforks.Before: overview metrics were a fixed-width
Wrap, activity/orders forked at page width 1050, and chart grids usedGridTrack.fixed(328 + padding)/420 * scaling.After:
GridBox4→2→1 viaonConstraintsautoRows(content-sized); plot height lives onDashboardChartCard(220 × scaling)GridBox2→1GridBox2→1Published
remix/remix_fortalstill declare hostedmix: ^2.2.0-beta.4. The workspace override is the only git pin.Related Issues
None.
Checklist
///).Breaking Change
Does this PR require users of the package to manually update their code?
Validation
fvm flutter testinapps/dashboard— 53 passedfvm dart analyze apps/dashboard— no issuesOverflowBoxonStatCard.Risk and rollout
melos run mix:consumer:checkfails by design while runtime Mix is git-overridden. Do not weakentool/check_consumer_mix.dartfor this experiment. Drop the override once Mix #1031 ships on pub.Review notes (0 bugs, 3 suggestions): the activity
1049breakpoint now sees the padded Grid width, so a 1366 window with sidebar stacks earlier than the old page-width fork.