Adding languages to variable names - #1540
Open
MiraAhmedovic wants to merge 3 commits into
Open
Conversation
AnnikaTjuka
reviewed
Aug 20, 2026
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
Collaborator
There was a problem hiding this comment.
We have a different convention in Concepticon and don't add the language names to the variables. Sorry, they need to be deleted again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"Additional information
I added the languages to some variable names and changing some variable names for comparability. For Xiao-2012-213, I did not include the language in the variable name because the trial was done on native English speakers using Chinese words. This PR is related to an update of the TYPES column in
norare.tsvover in the norare repo, PR #359.