set default for var that won't exist on forked repo PRs - #178
Merged
chrishagglund-ship-it merged 1 commit intoSep 9, 2026
Merged
Conversation
…nt e2e from forked repos since it will not have the secrets either
chrishagglund-ship-it
marked this pull request as ready for review
September 9, 2026 15:39
chrishagglund-ship-it
requested review from
bradyyie,
nthmost-orkes and
v1r3n
September 9, 2026 17:54
nthmost-orkes
approved these changes
Sep 9, 2026
nthmost-orkes
left a comment
nthmost-orkes
left a comment
Contributor
There was a problem hiding this comment.
approving to unblock!
nthmost-orkes
deleted the
fix/ci-defaults-for-vars-that-forks-cannot-resolve
branch
September 9, 2026 21:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should unblock #176
Fork PRs get no org/repo variables (same as secrets), so
E2E_TEST_OSS_CONDUCTOR_VERSIONresolved empty and failedintegration_tests_oss. It now falls back to3.32.3.agent-e2eneeds LLM secrets forks can't have, so it skips rather than burning the full 45min timeout. Not much we can do about that one.