Skip to content

Pin mcp<2 in agent-e2e - #474

Merged
manan164 merged 1 commit into
mainfrom
fix/pin-mcp-below-2
Aug 13, 2026
Merged

Pin mcp<2 in agent-e2e#474
manan164 merged 1 commit into
mainfrom
fix/pin-mcp-below-2

Conversation

@ling-senpeng13

@ling-senpeng13 ling-senpeng13 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

mcp 2.0.0 removed mcp.server.fastmcp, which mcp-testkit still imports — the testkit died on import and test_suite4_mcp_tools.py failed collection. mcp was unpinned (transitive via claude-code-sdk).

Also probe the port instead of sleep 2, so a dead testkit fails its own step.

https://github.com/conductor-oss/python-sdk/actions/runs/31633373975/job/94237499406?pr=471

/opt/hostedtoolcache/Python/3.12.13/x64/lib/python3.12/site-packages/mcp_test_server/tools/echo_tools.py:5: in <module>
    from mcp.server.fastmcp.exceptions import ToolError
E   ModuleNotFoundError: No module named 'mcp.server.fastmcp'
- generated xml file: /home/runner/work/python-sdk/python-sdk/results/junit-e2e.xml -
=========================== short test summary info ============================
ERROR e2e/test_suite4_mcp_tools.py - ImportError while importing test module '/home/runner/work/python-sdk/python-sdk/e2e/test_suite4_mcp_tools.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.12.13/x64/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
e2e/test_suite4_mcp_tools.py:52: in <module>
    EXPECTED_TOOL_NAMES = _expected_tools_from_source()
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

mcp 2.0.0 removed mcp.server.fastmcp, which mcp-testkit 1.0.3 still
imports. mcp arrives transitively (claude-code-sdk: mcp>=0.1.0) and was
unpinned, so CI resolved 2.0.0: the testkit process died on import and
e2e/test_suite4_mcp_tools.py failed collection.

Also replace the blind `sleep 2` after starting the testkit with a port
probe — the backgrounded process crashing left that step green, so the
real cause only surfaced as a collection error and downstream skips.
@manan164
manan164 merged commit 42aa983 into main Aug 13, 2026
22 of 27 checks passed
@ling-senpeng13
ling-senpeng13 deleted the fix/pin-mcp-below-2 branch August 13, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants