Pin mcp<2 in agent-e2e - #474
Merged
Merged
Conversation
mcp 2.0.0 removed mcp.server.fastmcp, which mcp-testkit 1.0.3 still imports. mcp arrives transitively (claude-code-sdk: mcp>=0.1.0) and was unpinned, so CI resolved 2.0.0: the testkit process died on import and e2e/test_suite4_mcp_tools.py failed collection. Also replace the blind `sleep 2` after starting the testkit with a port probe — the backgrounded process crashing left that step green, so the real cause only surfaced as a collection error and downstream skips.
ling-senpeng13
force-pushed
the
fix/pin-mcp-below-2
branch
from
August 12, 2026 21:15
61eba30 to
bec2aa8
Compare
manan164
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mcp 2.0.0 removed
mcp.server.fastmcp, which mcp-testkit still imports — the testkit died on import andtest_suite4_mcp_tools.pyfailed collection.mcpwas unpinned (transitive via claude-code-sdk).Also probe the port instead of
sleep 2, so a dead testkit fails its own step.https://github.com/conductor-oss/python-sdk/actions/runs/31633373975/job/94237499406?pr=471