bind-mount: suppress unused end_tab warning when NDEBUG is set#750
Open
heitbaum wants to merge 1 commit into
Open
bind-mount: suppress unused end_tab warning when NDEBUG is set#750heitbaum wants to merge 1 commit into
heitbaum wants to merge 1 commit into
Conversation
Silence -Wunused-but-set-variable on end_tab by moving the assignment directly into the assert expression.
Fixes:
../bind-mount.c: In function 'parse_mountinfo':
../bind-mount.c:237:14: warning: variable 'end_tab' set but not used [-Wunused-but-set-variable=]
237 | MountInfo *end_tab;
| ^~~~~~~
Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
charmander
suggested changes
May 5, 2026
charmander
left a comment
charmander
left a comment
There was a problem hiding this comment.
This will fail to call collect_mounts at all when NDEBUG is set.
|
A simple |
smcv
requested changes
May 29, 2026
smcv
left a comment
smcv
left a comment
Collaborator
There was a problem hiding this comment.
If built with -DNDEBUG, the proposed change won't call collect_mounts() at all, but the whole point is that we want to call it for its side-effects (populating the table).
I'd prefer:
- MountInfo *end_tab;
+ MountInfo *end_tab UNUSED /* if NDEBUG */;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silence -Wunused-but-set-variable on end_tab by moving the assignment directly into the assert expression.
Fixes:
../bind-mount.c: In function 'parse_mountinfo':
../bind-mount.c:237:14: warning: variable 'end_tab' set but not used [-Wunused-but-set-variable=]
237 | MountInfo *end_tab;
| ^~~~~~~