Add option to set container name

[dododedodonl]

When converting from a compose file, container_name might not be set. The flag added gives the option to set the service's key as container name when it is not set already.

[k9withabone]

@TheRealBecks what do you think of this new option?

[TheRealBecks]

I may have overlooked it, but how do I set --add-container-name when there are several services defined? When there's no container_name Podman generates names for services as <project-name>-<service-name>-<number-starting-at-1>.

Also container_name does not allow scaling as there can't be two containers with the same name for one service, see compose-spec#container_name

So keep in mind that this command collides with:

• scale
• replicas

@k9withabone Is there a way to make scale and container_name mutually exclusive per service? replicas is not yet implemented.

[TheRealBecks]

@k9withabone Any thoughts on this?

[k9withabone]

As replicas is part of the Compose Deploy Specification, which is not supported, we don't have to worry about that. My understanding is that deploy is for when you are deploying your Compose file to some PaaS (platform as a service), so it doesn't make sense for Podlet to ever support it.

I believe scale is used by Docker Swarm which doesn't have a Podman equivalent, so it's not supported by Podlet.

[TheRealBecks]

Okay, so let's come back to my first question:

@dododedodonl I may have overlooked it, but how do I set --add-container-name when there are several services defined?

[dododedodonl]

Okay, so let's come back to my first question:

@dododedodonl I may have overlooked it, but how do I set --add-container-name when there are several services defined?

In a lot of my docker-compose files, no container name is set, only a service name with only one container. This toggle allows a user to use the service name as container name, instead of relying on the auto generated <project-name>-<service-name>-<number-starting-at-1>, it becomes <service-name>.

[TheRealBecks]

@dododedodonl Thanks, I finally understand how this works: It a boolean flag, I missed that directly at the beginning of the source code 😂

@k9withabone Yeah, this feature sounds good to me!

@dododedodonl Please rebase again