build: Style fix#1802
Open
debarshiray wants to merge 3 commits into
Open
Conversation
containers#1801 Signed-off-by: Ferenc Géczi <ferenc.gm@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the go-build-wrapper script to correct the syntax for passing the --unresolved-symbols option to the linker via -Wl, changing the separator from = to ,. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Jun 5, 2026
Use a comma to pass an argument to an external linker option instead of an equal sign for consistency. It was originally copied verbatim from the NVIDIA Container Toolkit [1], which itself has this inconsistency. Fallout from 66280a6 [1] NVIDIA Container Toolkit commit 772cf77dcc2347ce NVIDIA/nvidia-container-toolkit@772cf77dcc2347ce NVIDIA/nvidia-container-toolkit#333 containers#1802
debarshiray
force-pushed
the
wip/rishi/src-go-build-wrapper-extldflags-use-comma-not-equal
branch
from
def89d8 to
730326c
Compare
Use a comma to pass an argument to an external linker flag instead of an equal sign for consistency. It was originally copied verbatim from the NVIDIA Container Toolkit [1], which itself has this inconsistency. Fallout from 66280a6 [1] NVIDIA Container Toolkit commit 772cf77dcc2347ce NVIDIA/nvidia-container-toolkit@772cf77dcc2347ce NVIDIA/nvidia-container-toolkit#333 containers#1802
debarshiray
force-pushed
the
wip/rishi/src-go-build-wrapper-extldflags-use-comma-not-equal
branch
from
730326c to
ebee6ab
Compare
Fallout from 66280a6 containers#1802
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a comma to pass an argument to an external linker option instead of an equal sign for consistency. It was originally copied verbatim from the NVIDIA Container Toolkit [1], which itself has this inconsistency.
Fallout from 66280a6
[1] NVIDIA Container Toolkit commit 772cf77dcc2347ce
NVIDIA/nvidia-container-toolkit@772cf77dcc2347ce
NVIDIA/nvidia-container-toolkit#333