fix: implement __eq__ and __ne__ for CopyOnWriteList - #136
Merged
araujof merged 2 commits intoAug 4, 2026
Conversation
Signed-off-by: Matej Klima <matej.klima5@gmail.com>
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
araujof
force-pushed
the
fix/copyonwritelist-equality-bug
branch
from
August 4, 2026 20:47
e8a3226 to
389a04a
Compare
araujof
approved these changes
Aug 4, 2026
araujof
left a comment
araujof
left a comment
Contributor
There was a problem hiding this comment.
Nice work!
I confirmed the bug, and pushed a few nits directly to the PR branch.
Thanks for this PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes equality comparison bug where CopyOnWriteList compared equal to [] even when containing data from its wrapped original list. This caused apply_policy() to incorrectly drop valid payload modifications when a plugin filtered a list down to empty (e.g. an authorization plugin denying every item in a listing), so the gateway would silently fall back to serving the original, unfiltered list.
Closes: #135
Changes
sequence contents rather than the empty backing list storage
all-denied-listing flow in test_policies.py
Checks
make lintpassesmake testpassesNotes (optional)
Design sketch, screenshots, or extra context.