Skip to content

fix: snapshot CoW containers so inherited methods see real data #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
araujof wants to merge 1 commit into
base: 0.1.x
Choose a base branch
from
+459 −229
Open

fix: snapshot CoW containers so inherited methods see real data #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,20 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).

## [Unreleased]

### Changed

- `CopyOnWriteDict` / `CopyOnWriteList` now snapshot the wrapped container at construction instead of reading through to it lazily ([#152](https://github.com/contextforge-org/cpex/issues/152))
- Mutating the original *after* wrapping is no longer visible through the wrapper — isolation is now symmetric. The lazy implementation leaked such mutations in
- The wrapper no longer retains a reference to the original container
- Small construction cost: snapshotting up front measures 0.26 us vs 0.17 us (100-item list) and 0.43 us vs 0.20 us (100-key dict) against the lazy wrapper. Still ~38-45x cheaper than the `copy.deepcopy()` it exists to avoid, so the isolation path stays sub-microsecond per wrap

### Fixed

- CopyOnWrite containers no longer lose or duplicate data in inherited methods ([#152](https://github.com/contextforge-org/cpex/issues/152))
- `model_dump()` / `model_dump_json()` / `json.dumps()` of a CoW-isolated payload returned empty containers, silently stripping `items` / `args` / headers — this reached external (gRPC/Unix-socket) plugins, which receive payloads via `model_dump()`
- `copy.deepcopy()` and `model_copy(deep=True)` duplicated every element of a `CopyOnWriteList`
- `CopyOnWriteList`: fixed `<`, `<=`, `>`, `>=`, `+`, `*`, `+=`, `*=`, `index()`, `count()` and `reversed()`; `+=` was a silent no-op
- `CopyOnWriteDict`: fixed `|`, `|=`, `popitem()` and `reversed()`
- Implement `__eq__` and `__ne__` for CopyOnWriteList ([#136](https://github.com/contextforge-org/cpex/pull/136))

## [0.1.2] - 2026-07-29
Expand Down
Loading
Loading