Export windowContent from the package index - #6
Merged
Conversation
windowContent is defined and exported in src/tools.ts but never re-exported from the index, and the exports map serves only "." — so consumers cannot reach it. readArtifactChunk isn't a substitute: it requires an Identity/ResolvedPrincipal and returns a different shape, so the plain 'window this string I already have' case had no public entry point (Scout re-implemented it as a result). CL-4971
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windowContentis exported fromsrc/tools.tsbut never re-exported fromsrc/index.ts, and the exports map serves only"."— so no consumer can import it.readArtifactChunkisn't a substitute: it requires anIdentity/ResolvedPrincipaland returns a different shape, so the plain "window a string I already have" case had no public entry point. Scout re-implemented it verbatim as a result (found in a reinvented-wheel audit).One-line re-export, no behavior change. Did not install/run the suite locally (constrained environment) — relying on CI.
Fixes CL-4971