Split the event log into pure line-assembly and React presentation modules - #286
Merged
TheGreatAxios merged 1 commit intoAug 2, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-4365-split-the-event-log-into-assembly-and-component-modules
branch
from
August 1, 2026 04:56
64d3ff9 to
08efc0d
Compare
TheGreatAxios
force-pushed
the
cl-4365-split-the-event-log-into-assembly-and-component-modules
branch
from
August 1, 2026 22:15
08efc0d to
f69e034
Compare
TheGreatAxios
force-pushed
the
cl-4365-split-the-event-log-into-assembly-and-component-modules
branch
from
August 1, 2026 22:15
f69e034 to
f38ea5f
Compare
TheGreatAxios
marked this pull request as ready for review
August 2, 2026 03:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the pure line-assembly, caching, wrapping, and viewport-windowing logic out of
src/tui/components/event-log.tsxinto a newsrc/tui/components/event-log-assembly.tsmodule with zero React/Ink imports.event-log.tsxnow imports from the assembly module and keeps only the React components (EventLog,RenderedLine,RunningToolRow) and re-exports the assembly module's public API for existing callers. Pure code motion — no logic changes.New file:
src/tui/components/event-log-assembly.tssrc/tui/components/event-log.tsxdrops from 1486 to 169 lines;event-log-assembly.tsholds the extracted 1351 lines.Closes CL-4365
Verification
bun run typecheck— passesbun run build— passesbun test— 3565 pass, 0 fail, across 274 files (full suite)rg -n "from ['\"](react|ink)" src/tui/components/event-log-assembly.ts— no matches, confirming zero React/Ink imports