Attribute approval prompts to the sub-agent requesting them - #289
Merged
TheGreatAxios merged 2 commits intoAug 4, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-4865-approval-prompts-must-clearly-identify-which-sub-agent-is
branch
2 times, most recently
from
August 2, 2026 04:09
46513dd to
c29f8ee
Compare
TheGreatAxios
force-pushed
the
cl-4865-approval-prompts-must-clearly-identify-which-sub-agent-is
branch
from
August 2, 2026 04:38
c29f8ee to
620abb4
Compare
TheGreatAxios
force-pushed
the
cl-4865-approval-prompts-must-clearly-identify-which-sub-agent-is
branch
2 times, most recently
from
August 4, 2026 00:12
78a3024 to
891f013
Compare
Each sub-agent's tool calls now run under its own identity (dispatch description + cwd) in async-local storage, so a permission request raised from a sub-agent carries that agent's label instead of looking like a top-level request. The approval modal shows the requesting agent and its working directory prominently, and the queued-behind list shows every other pending approval with a per-agent color tag so requests from different agents read as visually distinct.
Two overlapping runWithSubAgentIdentity scopes must not cross-contaminate agentLabel or cwd on the permission requests they raise.
TheGreatAxios
force-pushed
the
cl-4865-approval-prompts-must-clearly-identify-which-sub-agent-is
branch
from
August 4, 2026 00:27
891f013 to
96049e7
Compare
TheGreatAxios
marked this pull request as ready for review
August 4, 2026 03:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run typecheck && bun run build && bun test— full suite passes (3573/3573)Closes CL-4865