Permission-wait and subagent spans (CL-5170) - #308
Merged
Conversation
TheGreatAxios
force-pushed
the
stack/w2a-cl-5171-auto-spans
branch
from
August 4, 2026 16:21
1eb6a74 to
ddb9c72
Compare
TheGreatAxios
force-pushed
the
stack/w3b-cl-5170-perm-subagent
branch
2 times, most recently
from
August 4, 2026 16:29
90e035b to
e6cb5d9
Compare
TheGreatAxios
force-pushed
the
stack/w2a-cl-5171-auto-spans
branch
from
August 4, 2026 18:10
ddb9c72 to
c3442c6
Compare
TheGreatAxios
force-pushed
the
stack/w3b-cl-5170-perm-subagent
branch
from
August 4, 2026 18:10
c40f4e8 to
a28796d
Compare
TheGreatAxios
force-pushed
the
stack/w2a-cl-5171-auto-spans
branch
from
August 4, 2026 22:42
c3442c6 to
073d6de
Compare
Always end the wait span in finally when requestApproval throws. Move the process-wide turn id into active-turn so clear() and turn close both null the nesting slot used by gate and task spans.
Gate path with operator message free text must only land tool_id + allow/deny enums on the span; reason stays operator-facing only.
Concurrent multi-observer setups overwrite the process-wide turn parent used by permission.wait and subagent spans.
Start the exclusive subagent span before worktree setup and end it after teardown so attribution includes prepare and cleanup, including prepare failures that never reach run().
Bare return of finishWithWorktree ran the outer finally before teardown settled. return await keeps cleanup inside the exclusive child wall.
TheGreatAxios
force-pushed
the
stack/w3b-cl-5170-perm-subagent
branch
from
August 4, 2026 22:44
5b79189 to
b01d246
Compare
TheGreatAxios
changed the base branch from
stack/w2a-cl-5171-auto-spans
to
main
August 4, 2026 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
PerfTrace stack 3c/8 — base:
stack/w2a-cl-5171-auto-spansLinear
https://linear.app/abklabs/issue/CL-5170/permission-wait-and-subagent-spans
Summary
Add permission.wait and subagent spans so attribution can separate ask-gate idle and fanout cost from inference/tools.
Test evidence
Merge note
Merge after CL-5171. Parallel with dump/rollup and OTEL settings.